Cleanup Tests and Warnings in them #1205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@distrustME is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
# Conflicts: # tests/renderStatsCard.test.js # tests/renderTopLanguages.test.js
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1205 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 27 27
Lines 6275 6275
Branches 549 549
=======================================
Hits 6151 6151
Misses 121 121
Partials 3 3 ☔ View full report in Codecov by Sentry. |
# Conflicts: # tests/renderTopLanguages.test.js # tests/utils.test.js
rickstaa
force-pushed
the
master
branch
2 times, most recently
from
86aafe8 to
8bc69e7
Compare
github-actions
bot
added
⭐ top pull request
github-actions
bot
added
⭐ top pull request
github-actions
bot
added
stats-card
# Conflicts: # tests/renderStatsCard.test.js
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've cleanuped the tests a bit and fixed some warnings. Jest only spitted out the warning that
toBeEmpty()is deprecated andtoBeDOMElement()should be used instead, but i also refactored other tests in this PR. MainlyrenderStatsCard.test.js, because it had multiple duplicate code-fragments that should be refactored for faster readability.Code
expectColors()to avoid duplicate code fragmentsTypes of changes
Reference