Top languages card donut vertical layout

[qwerty541]

Preview deployed there: https://github-readme-stats-1svgrsiyn-qwerty541.vercel.app

Option: https://github-readme-stats-1svgrsiyn-qwerty541.vercel.app/api/top-langs?username=qwerty541&layout=donut-vertical

TODOS:

• rebase master
• refactoring
• docs
• tests
• animations

[vercel]

@qwerty541 is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (6d45f89) 97.53% compared to head (7cde69e) 97.58%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2701      +/-   ##
==========================================
+ Coverage   97.53%   97.58%   +0.04%     
==========================================
  Files          24       24              
  Lines        4630     4725      +95     
  Branches      423      428       +5     
==========================================
+ Hits         4516     4611      +95     
  Misses        112      112              
  Partials        2        2              

Impacted Files	Coverage Δ
src/cards/top-languages-card.js	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rickstaa]

Hey @qwerty541. I think it is wonderful that you have contributed so much to the project in the last days 🚀! I asked @anuraghazra to add you as a collaborator. You are welcome to accept or decline 👍🏻.

Sadly, the donut layout has already been implemented in #2099 😅. I am planning to merge it this week when the @arndom implements the changes I requested. You can find the other top bugs, feature requests and pull requests in #1935.

[qwerty541]

Hey @qwerty541. I think it is wonderful that you have contributed so much to the project in the last days 🚀! I asked @anuraghazra to add you as a collaborator. You are welcome to accept or decline 👍🏻.

Sadly, the donut layout has already been implemented in #2099 😅. I am planning to merge it this week when the @arndom implements the changes I requested. You can find the other top bugs, feature requests and pull requests in #1935.

Hey @rickstaa. Thank you for the collaboration invitation, i am going to accept it when it will be sent.

I feel like a fool for not checking for open pull requests on the issue before starting to work. I'll try to be more careful in the future.

I want to draw your attention to what my pull request offers a DIFFERENT design of top languages card with donut than #2099. In my pull request, the objects are arranged vertically, the amount of empty space is minimized, the card turned out to be quite compact. In another pull request, the objects are arranged horizontally, the card turned out to be quite cumbersome, and it has an obvious disadvantage, which is that with a large number of different languages there will be a lot of empty space above and below the donut. For this reason, some users may prefer to use my design. What do you think about supporting both layouts like donut-vertical and donut-horizontal?

[rickstaa]

Hey @qwerty541. I think it is wonderful that you have contributed so much to the project in the last days rocket! I asked @anuraghazra to add you as a collaborator. You are welcome to accept or decline 👍🏻.
Sadly, the donut layout has already been implemented in #2099 sweat_smile. I am planning to merge it this week when the @arndom implements the changes I requested. You can find the other top bugs, feature requests and pull requests in #1935.

Hey @rickstaa. Thank you for the collaboration invitation, i am going to accept it when it will be sent.

I feel like a fool for not checking for open pull requests on the issue before starting to work. I'll try to be more careful in the future.

I want to draw your attention to what my pull request offers a DIFFERENT design of top languages card with donut than #2099. In my pull request, the objects are arranged vertically, the amount of empty space is minimized, the card turned out to be quite compact. In another pull request, the objects are arranged horizontally, the card turned out to be quite cumbersome, and it has an obvious disadvantage, which is that with a large number of different languages there will be a lot of empty space above and below the donut. For this reason, some users may prefer to use my design. What do you think about supporting both layouts like donut-vertical and donut-horizontal?

Hey @rickstaa. Thank you for the collaboration invitation, i am going to accept it when it will be sent.

Amazing! It would be an honour to have you on the team 🚀.

I feel like a fool for not checking for open pull requests on the issue before starting to work. I'll try to be more careful in the future.

No problem, it is easy to get lost in 180 open pull requests 😅. That is why merging #2489 is a high priority since that will remove 36 translation repositories.

I want to draw your attention to what my pull request offers a DIFFERENT design of top languages card with donut than #2099. In my pull request, the objects are arranged vertically, the amount of empty space is minimized, the card turned out to be quite compact. In another pull request, the objects are arranged horizontally, the card turned out to be quite cumbersome, and it has an obvious disadvantage, which is that with a large number of different languages there will be a lot of empty space above and below the donut. For this reason, some users may prefer to use my design. What do you think about supporting both layouts like donut-vertical and donut-horizontal?

I think having two donut layouts is great if duplicate code is kept to the minimum. Let's keep this PR open so that you can rebase it on top of the master branch when #2099 is merged.

[rickstaa]

@qwerty541 I just merged #2099.

[qwerty541]

@rickstaa Hey, Rick! I finished work on this pull request, can you review it?

[rickstaa]

Great pull request! Merged into master 🚀.