Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Cards of all types of Literary Realms accordingly #2789

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

kashvi9
Copy link
Contributor

@kashvi9 kashvi9 commented Aug 7, 2024

Related Issue

None

Fixes: #2770

Description

  1. The text was not properly visible in cards, I've fixed that by adjusting width and height for all literary realms' categories
  2. The text in cards was same for all the types, have changed them according to the realm type.

Issue- #2770

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Here's a before screenshot of how it looked for Mindful Living Realm:
image

It looked the same for all realms.
Here's how it looks now for different realms:

  1. Romantic Escapes
    image
  2. Thrilling Adventures
    image
  3. Mindful Living
    image
  4. Mystical Fantasies
    image
  5. Historical Chronicles
    image
  6. Science Fiction Wonders
    image
  7. Laugh Out Loud Comedies
    image
  8. Intriguing Mysteries
    image
  9. Biographies
    image

Checklist:

  • I have made this change from my own.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 5:40pm

Copy link

github-actions bot commented Aug 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for vermillion-sunshine-40461e ready!

Name Link
🔨 Latest commit cebbdb2
🔍 Latest deploy log https://app.netlify.com/sites/vermillion-sunshine-40461e/deploys/66b502ec325e640008247a1d
😎 Deploy Preview https://deploy-preview-2789--vermillion-sunshine-40461e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RitiChandak
Copy link
Collaborator

image
please resolve conflicts

@huamanraj huamanraj merged commit ad026ff into anuragverma108:main Aug 9, 2024
7 checks passed
@huamanraj huamanraj added gssoc This Contribution is under GirlScript Summer of Code 2024 level1 Basic labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This Contribution is under GirlScript Summer of Code 2024 level1 Basic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: The text is not properly visible on Literary Realms' Intriguing Mysteries Page
3 participants