Feature/JS-5752: Url preview logic #1065
Open
+66
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ra3orblade
requested changes
Nov 21, 2024
| @@ -87,7 +88,7 @@ const ChatAttachment = observer(class ChatAttachment extends React.Component<Pro | |||
| }; | |||
|
|
|||
| case I.ObjectLayout.Bookmark: { | |||
| content = this.renderBookmark(); | |||
| content = bookmarkAsDefault ? this.renderDefault() : this.renderBookmark(); | |||
There was a problem hiding this comment.
Do not understand how this should work
There was a problem hiding this comment.
i pass bookmarkAsDefault=true in case there are more than 1 attachment in the message and for all attachments in the message form
haron-IV
reviewed
Nov 22, 2024
Comment on lines
+488
to
+498
| window.setTimeout(() => { | ||
| for (const url of urls) { | ||
| const { from, to, isLocal, value } = url; | ||
| const param = isLocal ? `file://${value}` : value; | ||
|
|
||
| this.marks = Mark.adjust(this.marks, from - 1, value.length + 1); | ||
| this.marks.push({ type: I.MarkType.Link, range: { from, to }, param}); | ||
| this.addBookmark(param, true); | ||
| }; | ||
| this.updateMarkup(text, this.range.to + 1, this.range.to + 1); | ||
| }, 150); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?