Topic/fault tolerance #34
Open
+991
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
Aug 10, 2021
Comment on lines
82
to
90
| class RayPythonOperator(PythonOperator): | ||
|
|
||
| def __init__(self, *, | ||
| python_callable: Callable, | ||
| op_args: Optional[List] = None, | ||
| op_kwargs: Optional[Dict] = None, | ||
| templates_dict: Optional[Dict] = None, | ||
| templates_exts: Optional[List[str]] = None, | ||
| **kwargs) -> None: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh, this is basically the implementation of the task?
There was a problem hiding this comment.
Can you leave a docstring here?
There was a problem hiding this comment.
Previously, the ray decorator used the PythonOperator.
Assigning the recovered objects as Task attributes requires modifying to the pre_execute method of the PythonOperator.
RayPythonOperator subclasses the PythonOperator; it sets a custom pre_execute method and implements logic to enable attribute assignment.
- I will add docstrings explaining the implementation.
…m. Clean-up logs and docstrings. Standardize naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fault Tolerance mechanism is now functional.
To-do: