Refactor remove_uncleaned_slots to reduce memory consumption #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakarov
force-pushed
the
cleaning
branch
2 times, most recently
from
72d178b
to
7cc70c2
Compare
brooksprumo
reviewed
Sep 19, 2024
HaoranYi
approved these changes
Sep 21, 2024
| &self, | ||
| max_slot_inclusive: Slot, | ||
| ) -> Vec<Vec<Pubkey>> { | ||
| candidates: &[RwLock<HashMap<Pubkey, CleaningInfo>>], |
There was a problem hiding this comment.
I wonder if there is a case that we don't need filter "up_to_slot"?
If so, maybe we could make max_slot_inclusive Option?
| /// returns the minimum slot we encountered | ||
| fn insert_pubkey(&self, candidates: &[RwLock<HashMap<Pubkey, CleaningInfo>>], pubkey: Pubkey) { | ||
| let index = self.accounts_index.bin_calculator.bin_from_pubkey(&pubkey); | ||
| let mut candidates_bin = candidates[index].write().unwrap(); |
There was a problem hiding this comment.
nit: maybe we could sort and group the pubkeys by bins and insert all pubkeys to the same bin at once.
This will save the repeated costs of lock and unlock of the same bin, also we may have better cache locality.
There was a problem hiding this comment.
I’ll make a follow-up PR. Thank you.
brooksprumo
approved these changes
Sep 21, 2024
|
@jeffwashington should I wait for your review, or ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cleaning algorithm creates many temporary data sets that consume significant amount of heap, increasing memory requirements of the validator.
Summary of Changes
Avoid making another temporary container of pubkeys that are candidates for cleaning.
This change reduces the used heap memory by 14% on a sample snapshot cleaning from 166,737,546,218 to 143,515,886,322 bytes.
Also collapse two small functions where the first is the only caller of the second into a single function, and remove a unit test that is almost a duplicate of another existing test that exercises the first of the functions.