Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add interactive shell #4

Merged
merged 17 commits into from
Dec 19, 2023
Merged

Conversation

shtayeb
Copy link
Contributor

@shtayeb shtayeb commented Dec 18, 2023

Execute python code in your Django app context.

@anze3db
Copy link
Owner

anze3db commented Dec 18, 2023

I played around with it, and I like it. I agree it's much more convenient than using python manage.py shell. Let's figure out how to include it!

I'm not a fan of the selector as the first screen, but I think a key action (ctrl+i is already used by trogon, but I think ctrl+j works well) to switch to the interactive shell screen and back works well.

We could also add a command line argument as a shortcut to go directly into the interactive shell, something like:

python manage.py tui shell # to open up the new interactive shell directly

What do you think?

@shtayeb
Copy link
Contributor Author

shtayeb commented Dec 19, 2023

I played around with it, and I like it. I agree it's much more convenient than using python manage.py shell. Let's figure out how to include it!

I'm not a fan of the selector as the first screen, but I think a key action (ctrl+i is already used by trogon, but I think ctrl+j works well) to switch to the interactive shell screen and back works well.

We could also add a command line argument as a shortcut to go directly into the interactive shell, something like:

python manage.py tui shell # to open up the new interactive shell directly

What do you think?

I agree 100%

@shtayeb
Copy link
Contributor Author

shtayeb commented Dec 19, 2023

@anze3db, I added your suggestions.

You can now open shell directly with python manage.py tui --shell and switch to commands and shell with ctrl+j.

@anze3db
Copy link
Owner

anze3db commented Dec 19, 2023

Looks good. I will merge and then do some cleanup/improvements and a new release. Thanks for the contribution, it looks awesome! 👍

@anze3db anze3db merged commit 776c8a4 into anze3db:main Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants