Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard provider bash operator #42252

Merged

Conversation

gopidesupavan
Copy link
Contributor

Moving bash operators/sensors to standard provider


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@gopidesupavan
Copy link
Contributor Author

moving this bash operator to standard provider, has module path changes in systems test, integration tests.

failures in python client tests, i am thinking due to bashoperator path change, causing dag not loaded.
Checking remaining tests.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@gopidesupavan
Copy link
Contributor Author

Could you please help on this, kubernetes executor tests are failing with dag not found example_kubernetes_executor and example_bash_operator. one option i tried copying the standard package to k8s build container, but its still failing with same reason.

@gopidesupavan
Copy link
Contributor Author

Additional prod image tests also failing, as it doesnt have the standard provider. inside latest prod image pull.
image

@gopidesupavan
Copy link
Contributor Author

Additional prod image tests also failing, as it doesnt have the standard provider. inside latest prod image pull. image

Any suggestions for these tests?

@gopidesupavan
Copy link
Contributor Author

gopidesupavan commented Sep 21, 2024

After reviewing the logs, it seems the reason the k8s tests are failing is due to the absence of the standard provider package in the image. This is because i guess the standard provider not included in the prod_image_installed_providers.txt file ?

Is it okay to add standard provider in to that file?

@gopidesupavan gopidesupavan force-pushed the standard-provider-bash-operator branch from 7745a13 to 726518b Compare October 8, 2024 20:39
@gopidesupavan
Copy link
Contributor Author

Oh, nooo, merge conflict - can you fix this? then LGTM!

yeah just resolved 3.8 removals 😄

There is a test failing , but its not related to this. Would you be able to merge please?

@romsharon98 romsharon98 merged commit a5ffbbd into apache:main Oct 9, 2024
105 checks passed
kunaljubce pushed a commit to kunaljubce/airflow that referenced this pull request Oct 13, 2024
Standard provider should be added to chicken-egg-providers as it
has not yet been officially released, so we need  to add it.

This can only be done via "apache" PR as it is needed in build-images
workflow. This is needed to unblock apache#42252
kunaljubce pushed a commit to kunaljubce/airflow that referenced this pull request Oct 13, 2024
pavansharma36 pushed a commit to pavansharma36/airflow that referenced this pull request Oct 14, 2024
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
Standard provider should be added to chicken-egg-providers as it
has not yet been officially released, so we need  to add it.

This can only be done via "apache" PR as it is needed in build-images
workflow. This is needed to unblock apache#42252
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
Standard provider should be added to chicken-egg-providers as it
has not yet been officially released, so we need  to add it.

This can only be done via "apache" PR as it is needed in build-images
workflow. This is needed to unblock apache#42252
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants