add env support for migratedatabase job #42345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgvishnuram
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
|
@jedcunningham i have added your recommendation is this mergeable |
romsharon98
approved these changes
Sep 25, 2024
pgvishnuram
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 15, 2024
* add env support for migratedatabase job * add test case for env config * update schema json for migrateDatabaseJob * fix ci failures * fix pre-commit ci for json schema
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* add env support for migratedatabase job * add test case for env config * update schema json for migrateDatabaseJob * fix ci failures * fix pre-commit ci for json schema
pgvishnuram
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 24, 2024
* add env support for migratedatabase job * add test case for env config * update schema json for migrateDatabaseJob * fix ci failures * fix pre-commit ci for json schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Issue Description: currently we don't support passing custom env values to migratedatabase unless its passed via .Values.env which is quite not flexible for user specific usecases
Resolution Done: This PR introduces env support for migratedatabase job to be passed as a standalone values migratedatabase