-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dry run for backfill #45062
Open
prabhusneha
wants to merge
16
commits into
apache:main
Choose a base branch
from
astronomer:backfill_dry_run
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add dry run for backfill #45062
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a7a1efd
Add dry run for backfill
d288934
Add dry run for backfill
5bd604e
Add tests for backfill dry runs
23b7b9b
Fix tests
51e15bd
Merge remote-tracking branch 'origin/backfill_dry_run' into backfill_…
723beda
Merge branch 'main' into backfill_dry_run
prabhusneha ab17ebf
create a separate endpoint
e0a7007
Merge branch 'main' into backfill_dry_run
prabhusneha ba67427
Merge branch 'main' into backfill_dry_run
prabhusneha dcf0e2d
Refactor _create_backfill function
96dd491
Merge branch 'main' into backfill_dry_run
prabhusneha 828907c
Fix static checks
b130be4
Fix static checks
f4b7602
Fix mysql static checks
3933445
Merge branch 'main' into backfill_dry_run
prabhusneha 644244f
Merge branch 'main' into backfill_dry_run
prabhusneha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will only have logical date, no data interval?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the logical date is a datetime, so for example for DAGs with schedules other than daily, the response will still include the dates on which the backfill will be triggered. I imagine that the user likely has an understanding of the dag's schedule when making a backfill request. Does including the data interval provide additional value in this context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data interval does not technically provide additional context; logical date is the only identifier when backfilling. With that said, I think the information is probably still convenient for the user since they wouldn’t need to check the schedule.