fix(c/driver/sqlite): Fix detection of extension loading in sqlite CMake #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
reviewed
May 21, 2024
|
Oh no! 😬 (I'll re-look at this tomorrow) |
paleolimbot
force-pushed
the
c-driver-sqlite-extension
branch
from
b391e7d
to
1665b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1499 I added a check for the ability to load extensions based on the presence of some text in sqlite3.h. I had interpreted the result of the check incorrectly (-1 meant "not found", whereas I'd thought that 0 meant "not found") such that the CMake tests still fail if you try to run them out of the box on MacOS. This PR enables a proper check of the output.