Skip to content

Commit

Permalink
add buffered data_pages to parquet column writer total bytes estimati…
Browse files Browse the repository at this point in the history
…on (#6862)

* add buffered data_pages to parquet column writer memory size estimation

* move to get estimated total bytes
  • Loading branch information
onursatici authored Dec 11, 2024
1 parent dc45d7d commit 06a0157
Showing 1 changed file with 25 additions and 1 deletion.
26 changes: 25 additions & 1 deletion parquet/src/column/writer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,11 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E> {
/// anticipated encoded size.
#[cfg(feature = "arrow")]
pub(crate) fn get_estimated_total_bytes(&self) -> u64 {
self.column_metrics.total_bytes_written
self.data_pages
.iter()
.map(|page| page.data().len() as u64)
.sum::<u64>()
+ self.column_metrics.total_bytes_written
+ self.encoder.estimated_data_page_size() as u64
+ self.encoder.estimated_dict_page_size().unwrap_or_default() as u64
}
Expand Down Expand Up @@ -3422,6 +3426,26 @@ mod tests {
assert!(stats.max_bytes_opt().is_none());
}

#[test]
#[cfg(feature = "arrow")]
fn test_column_writer_get_estimated_total_bytes() {
let page_writer = get_test_page_writer();
let props = Default::default();
let mut writer = get_test_column_writer::<Int32Type>(page_writer, 0, 0, props);
assert_eq!(writer.get_estimated_total_bytes(), 0);

writer.write_batch(&[1, 2, 3, 4], None, None).unwrap();
writer.add_data_page().unwrap();
let size_with_one_page = writer.get_estimated_total_bytes();
assert_eq!(size_with_one_page, 20);

writer.write_batch(&[5, 6, 7, 8], None, None).unwrap();
writer.add_data_page().unwrap();
let size_with_two_pages = writer.get_estimated_total_bytes();
// different pages have different compressed lengths
assert_eq!(size_with_two_pages, 20 + 21);
}

fn write_multiple_pages<T: DataType>(
column_descr: &Arc<ColumnDescriptor>,
pages: &[&[Option<T::T>]],
Expand Down

0 comments on commit 06a0157

Please sign in to comment.