Skip to content

Commit

Permalink
Pass options to HTTPBuilder in parse_url_opts (#5310) (#5311)
Browse files Browse the repository at this point in the history
  • Loading branch information
tustvold authored Jan 19, 2024
1 parent 8301b23 commit ff5a84d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions object_store/src/parse.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ impl ObjectStoreScheme {
}
}

#[cfg(any(feature = "aws", feature = "gcp", feature = "azure"))]
#[cfg(feature = "cloud")]
macro_rules! builder_opts {
($builder:ty, $url:expr, $options:expr) => {{
let builder = $options.into_iter().fold(
Expand Down Expand Up @@ -164,8 +164,7 @@ where
}
#[cfg(feature = "http")]
ObjectStoreScheme::Http => {
let url = &url[..url::Position::BeforePath];
Box::new(crate::http::HttpBuilder::new().with_url(url).build()?) as _
builder_opts!(crate::http::HttpBuilder, url, _options)
}
#[cfg(not(all(feature = "aws", feature = "azure", feature = "gcp", feature = "http")))]
s => {
Expand Down

1 comment on commit ff5a84d

@CarlKCarlK
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add line 167 back in or it will fail:

        let url = &url[..url::Position::BeforePath];

Please sign in to comment.