fix: parse string of scientific notation to decimal when the scale is 0 #5740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjshen
changed the title
|
INtegration CI failure due to #5719 |
tustvold
reviewed
May 13, 2024
| @@ -860,7 +860,7 @@ pub fn parse_decimal<T: DecimalType>( | |||
| "can't parse the string value {s} to decimal" | |||
| ))); | |||
| } | |||
| if fractionals == scale { | |||
| if fractionals == scale && scale != 0 { | |||
There was a problem hiding this comment.
It took me quite a while to work out what was going on here, the issue appears to be that parse_e_notation uses a non-zero fractionals to skip over the decimal point.
I think this can now overflow, but I think that is a broader issue with the e parsing logic. I will file a ticket
|
I thought it was a pre-existing issue, but actually the existing code handles this correctly. This PR therefore introduces an overflow bug - #5762 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5739.
Rationale for this change
Unable to parse scientific notation string when the scale is 0.
What changes are included in this PR?
Bug fix and also tests.
Are there any user-facing changes?
No.