Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Improve arrow_cast documentation #5825

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 31, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

I was working on another PR to improve the docs for the cast kernel itself, and I saw there were some improvements to the arrow_cast crate itself. For example, it is not clear from the docs that you can use Parser to parse strings to Date32 types (which I only learned myself when I saw @houqp do that in apache/datafusion#10693)

What changes are included in this PR?

  1. Improve the docs and add some examples

Are there any user-facing changes?

Better docs / more examples

This is documentation changes only, no code changes

@github-actions github-actions bot added the arrow Changes to the arrow crate label May 31, 2024
@alamb alamb added documentation Improvements or additions to documentation and removed arrow Changes to the arrow crate labels May 31, 2024
@github-actions github-actions bot added the arrow Changes to the arrow crate label May 31, 2024
@alamb
Copy link
Contributor Author

alamb commented May 31, 2024

CI https://github.com/apache/arrow-rs/actions/runs/9322426943/job/25663481114?pr=5825 is failing due to #5815

Otherwise this is ready for review

@alamb alamb marked this pull request as ready for review May 31, 2024 18:51
@tustvold tustvold merged commit 5a24119 into apache:master Jun 1, 2024
24 of 25 checks passed
@alamb alamb deleted the alamb/cast_docs branch June 1, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants