Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax zstd-sys Version Pin #5829

Merged
merged 7 commits into from
Jun 1, 2024
Merged

Relax zstd-sys Version Pin #5829

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
071ca75
build: pin zstd-sys to 2.0.7
waynexia Jun 1, 2024
fc4c06a
change to <=2.0.9
waynexia Jun 1, 2024
aa93cd1
<2.0.10
waynexia Jun 1, 2024
f8dd6e2
also limit package zstd
waynexia Jun 1, 2024
bce0179
try multi selectors
waynexia Jun 1, 2024
d7d5e9b
remove dep pin
waynexia Jun 1, 2024
8676a82
only pin for wasm target family
waynexia Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions parquet/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ lz4_flex = { version = "0.11", default-features = false, features = ["std", "fra
zstd = { version = "0.13.0", optional = true, default-features = false }
# TODO: temporary to fix parquet wasm build
# upstream issue: https://github.com/gyscos/zstd-rs/issues/269
zstd-sys = { version = "=2.0.7", optional = true, default-features = false }
zstd-sys = { version = "<=2.0.9", optional = true, default-features = false }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could pick up zstd-sys 1.0, please make sure we also have >= 2.0.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, that works 💯

chrono = { workspace = true }
num = { version = "0.4", default-features = false }
num-bigint = { version = "0.4", default-features = false }
Expand All @@ -82,7 +82,7 @@ lz4_flex = { version = "0.11", default-features = false, features = ["std", "fra
zstd = { version = "0.13", default-features = false }
# TODO: temporary to fix parquet wasm build
# upstream issue: https://github.com/gyscos/zstd-rs/issues/269
zstd-sys = { version = "=2.0.7", default-features = false }
zstd-sys = { version = "<=2.0.9", default-features = false }
serde_json = { version = "1.0", features = ["std"], default-features = false }
arrow = { workspace = true, features = ["ipc", "test_utils", "prettyprint", "json"] }
tokio = { version = "1.0", default-features = false, features = ["macros", "rt", "io-util", "fs"] }
Expand Down
Loading