feat: call try_merge recursively for list field #5852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnpw
changed the title
alamb
approved these changes
Jun 10, 2024
| @@ -483,6 +483,18 @@ impl Field { | |||
| )); | |||
| } | |||
| }, | |||
| DataType::List(field) => match &from.data_type { | |||
There was a problem hiding this comment.
I think we should also add support for DataType::LargeList https://docs.rs/arrow/latest/arrow/datatypes/enum.DataType.html#variant.LargeList
If you don't want to add it in this PR, I'll file a ticket to track and add it in a follow on
|
Thanks @alamb for the review. As per your suggestion I have added the change for |
alamb
approved these changes
Jun 11, 2024
| struct1 | ||
| ); | ||
|
|
||
| let mut list1 = Field::new( |
There was a problem hiding this comment.
Any chance we could add a test for LargeList too?
mnpw
changed the title
I added Lmk if this looks good |
|
Thanks @mnpw |
alamb
approved these changes
Jun 13, 2024
|
Thanks again @mnpw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5843.
Rationale for this change
Merging fields recursively is already performed for a field with datatype Struct. This PR extends that recursive merge to fields with List and LargeList datatypes.
What changes are included in this PR?
Field::try_mergeto call merge recursively if datatype is List and LargeListAre there any user-facing changes?
N/A