clean up ByteView construction #5879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
|
CI failed because the new linting rule is being applied in rust 1.79 👀 |
Waiting for #5881 to merge |
Merged! |
|
I merged up from main to get a clean CI run |
alamb
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Thank you very much @XiangpengHao -- very cool. Nice cleanup and speed improvement
| offset, | ||
| }; | ||
| views_builder.append(view.into()); | ||
| // Safety: the input was a valid array so it valid UTF8 (if string). And |
| let len = array.len(); | ||
| let str_values_buf = data.buffers()[1].clone(); | ||
| let offsets = data.buffers()[0].typed_data::<FROM::Offset>(); | ||
| let str_values_buf = byte_array.values().clone(); |
| builder | ||
| .try_append_view(block, start.as_usize() as u32, len as u32) | ||
| .unwrap(); | ||
| // Safety: (1) the buffer is valid (2) the offsets are valid (3) the values in between are of ByteViewType |
There was a problem hiding this comment.
I ran the benchmarks and this seems to have gotten another 8% performance improvement:
++ critcmp master byte-view-clean
group byte-view-clean master
----- --------------- ------
arrow_array_reader/StringViewArray/dictionary encoded, mandatory, no NULLs 1.00 511.7±1.16µs ? ?/sec 1.08 554.8±4.84µs ? ?/sec
arrow_array_reader/StringViewArray/dictionary encoded, optional, half NULLs 1.00 711.4±1.29µs ? ?/sec 1.03 729.7±1.41µs ? ?/sec
arrow_array_reader/StringViewArray/dictionary encoded, optional, no NULLs 1.00 513.7±1.25µs ? ?/sec 1.08 555.4±1.51µs ? ?/sec
arrow_array_reader/StringViewArray/plain encoded, mandatory, no NULLs 1.00 558.3±2.88µs ? ?/sec 1.08 602.8±2.51µs ? ?/sec
arrow_array_reader/StringViewArray/plain encoded, optional, half NULLs 1.00 740.2±3.73µs ? ?/sec 1.03 765.2±4.20µs ? ?/sec
arrow_array_reader/StringViewArray/plain encoded, optional, no NULLs 1.00 561.7±2.62µs ? ?/sec 1.08 606.8±2.68µs ? ?/sec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5878 .
Rationale for this change
Avoids manual construction, use unchecked when it is safe.
What changes are included in this PR?
Are there any user-facing changes?