chore: Remove not used cache in InstanceCredentialProvider #5888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
alamb
approved these changes
Jun 14, 2024
alamb
reviewed
Jun 14, 2024
| @@ -424,9 +424,6 @@ fn canonicalize_headers(header_map: &HeaderMap) -> (String, String) { | |||
| /// <https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html> | |||
| #[derive(Debug)] | |||
| pub struct InstanceCredentialProvider { | |||
| // https://github.com/apache/arrow-rs/issues/5884 | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
🤔 sine this is a pub field, this might qualify as a breaking change -- in which case we may need to hold the PR until main is open for breaking changes again. I plan to file a ticket to discuss the plan in the next day or two (I keep meaing to do it but I haven't found the time yet)
There was a problem hiding this comment.
This struct is crate private so this is not a breaking change
There was a problem hiding this comment.
gah! it would be nice if we followed the pattern to mark all such structs pub(crate) so it is clearer from the definition
There was a problem hiding this comment.
Probably a good first issue, FWIW very little is actually public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5884.
Rationale for this change
I have confirmed that this cache is not used.
What changes are included in this PR?
Remove
cacheinInstanceCredentialProviderAre there any user-facing changes?
None