fix: clippy warnings from nightly rust 1.82 #6348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
github-actions
bot
added
parquet
I remembered that |
Not in this case. I guess it's not a simple format problem but we need to rephase some sentences. I'd give it a try in a seperated follow-up PR (I tried a few cases and it turns out to be a not very trivial change...) |
Merged
findepi
pushed a commit
to sdf-labs/arrow-rs
that referenced
this pull request
Oct 31, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Find those warnings when working with nightly toolchain in #6336
What changes are included in this PR?
Fix new clippy warnings.
One rule I didn't touch is
too_long_first_doc_paragraph. This does make sense in some scenarios but lots of the reported doc comment have a long first sentence... 🙈Are there any user-facing changes?
No