Benchmark for bit_mask (set_bits) #6353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alamb |
andygrove
reviewed
Sep 3, 2024
andygrove
reviewed
Sep 3, 2024
andygrove
approved these changes
Sep 3, 2024
|
@alamb when you have a chance, feedbacks would be appreciated! |
alamb
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
This is very cool @kazuyukitanimura
I ran it locally
bit_mask/set_bits/offset_write_0_offset_read_0_len_1_datum_0
time: [3.9908 ns 4.0114 ns 4.0375 ns]
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe
bit_mask/set_bits/offset_write_0_offset_read_0_len_1_datum_173
time: [4.1214 ns 4.1350 ns 4.1481 ns]
bit_mask/set_bits/offset_write_0_offset_read_0_len_17_datum_0
time: [12.735 ns 12.762 ns 12.786 ns]
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) low mild
1 (1.00%) high mild
Benchmarking bit_mask/set_bits/offset_write_0_offset_read_0_len_17_datum_173: Collecting 100 samples in estimated 5.0000 s (324M iterations
bit_mask/set_bits/offset_write_0_offset_read_0_len_17_datum_173
time: [15.578 ns 15.635 ns 15.693 ns]
...And looks 👍
Thank you @andygrove for the review
| for offset_read in [0, 5] { | ||
| for len in [1, 17, 65] { | ||
| for datum in [0u8, 0xADu8] { | ||
| let x = (offset_write, offset_read, len, datum); |
There was a problem hiding this comment.
I personally found the masking / packing of these fields into x a little hard to read (as I had to maintain a mental mapping that x.2 meant len)
I would have personally found it easier to understand if they were named fields of a struct or maybe just passed by copy.
|
Thank you @andygrove @alamb |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Per #6288 (comment)
What changes are included in this PR?
Added the benchmark for bit_mask (set_bits)
Are there any user-facing changes?
No