object_store: Add enabled-by-default "fs" feature #6636
Conversation
|
/cc @tustvold |
tustvold
added
api-change
|
I had a quick look and this looks plausible, however, it is a breaking change and will therefore need to wait for the next major release |
Turbo87
force-pushed
the
object_store/optional-fs
branch
from
799e4cf to
77c3931
Compare
There was a problem hiding this comment.
Makes sense to me. Thank you @Turbo87
Could you also please add a test for clippy here:
Specifically these two combinations?
--no-deafult-features--no-default-features --features fs?
Turbo87
force-pushed
the
object_store/optional-fs
branch
from
77c3931 to
5efbd80
Compare
Turbo87
force-pushed
the
object_store/optional-fs
branch
from
5efbd80 to
0e496ac
Compare
| @@ -70,6 +70,10 @@ | |||
| //! | |||
| //! Feature flags are used to enable support for other implementations: | |||
| //! | |||
| #
There was a problem hiding this comment.
"local filesystem" should be removed from the list in the previous paragraph (GitHub doesn't let me add a comment there, but this one here:
arrow-rs/object_store/src/lib.rs
Line 69 in 13f3f21
There was a problem hiding this comment.
good catch. fixed! :)
Turbo87
force-pushed
the
object_store/optional-fs
branch
from
0e496ac to
a48eb8b
Compare
There was a problem hiding this comment.
Looks good. Please delay the merge until 0.12 though (see #6596).
I hope to be able to merge early next week |
Which issue does this PR close?
Closes #6055.
Rationale for this change
see #6055 😉
What changes are included in this PR?
This PR introduces a new
fsfeature for theobject_storecrate, which is enabled by default. If disabled, thelocalmodule is excluded from the crate and thewalkdirdependency is skipped.Are there any user-facing changes?
Only for users of
default-features = false, but since this crate did not have any default features before there probably won't be manyobject_storeusers that specifydefault-features = false.