Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make GetCatalogsBuilder sort catalog names #6864

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

niebayes
Copy link
Contributor

Which issue does this PR close?

Closes #6807.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

No.

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Dec 10, 2024
@niebayes niebayes changed the title fix: sort catalog names fix: make GetCatalogsBuilder sort catalog names Dec 10, 2024
@niebayes
Copy link
Contributor Author

@alamb PTAL

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @niebayes

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit

arrow-flight/src/sql/metadata/catalogs.rs Outdated Show resolved Hide resolved
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@alamb alamb merged commit c4dbf0d into apache:main Dec 13, 2024
12 checks passed
@alamb
Copy link
Contributor

alamb commented Dec 13, 2024

Thanks @niebayes and @tustvold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FlightSQL] GetCatalogsBuilder does not sort the catalog names
3 participants