chore: Upgrade to twoxhash 2.1 and use oneshot API for improved performance #6878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
twoxhash defines rust-version as 1.81.0 even though it builds OK with much older versions. I will move this to draft for now. FYI @shepmaster is it possible to lower the minimum rust version for twoxhash? |
|
See also #6583
I'm not sure I follow: |
|
Closed since #6583 already exists. Thank you @shepmaster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
There is a new version of
twoxhashthat has a newoneshotAPI for use cases where all data is available at once. This is more performant than the streaming API.Arrow uses this crate for hashing related to bloom filters.
We saw significant performance improvements in Comet with this approach, so hopefully it helps with arrow as well.
I tried benchmarking with
write_batchbenchmarks but am seeing highly variable results on my desktop, so I am not sure how to prove that this helps with performance.What changes are included in this PR?
Are there any user-facing changes?