Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: make it easier to find fix instructions when cargo fmt on parquet fails #6886

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Minor: make it easier to find fix instructions when cargo fmt on parquet fails #6886

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efe8af4
Minor: make it easier to find instructions when fmt fails
alamb Dec 16, 2024
440e520
purposely introduce a fmt issue
alamb Dec 16, 2024
3da1765
Revert "purposely introduce a fmt issue"
alamb Dec 16, 2024
371d281
Update .github/workflows/rust.yml
alamb Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,13 @@ jobs:
- name: Format arrow
run: cargo fmt --all -- --check
- name: Format parquet
# Many modules in parquet are skipped, so check parquet separately. If this check fails, run:
# cargo fmt -p parquet -- --config skip_children=true `find ./parquet -name "*.rs" \! -name format.rs`
# from the top level arrow-rs directory and check in the result.
# Many modules in parquet are skipped, so check parquet separately
# https://github.com/apache/arrow-rs/issues/6179
working-directory: parquet
run: cargo fmt -p parquet -- --check --config skip_children=true `find . -name "*.rs" \! -name format.rs`
run: |
# if this fails, run this from the parquet directory:
# cargo fmt -p parquet -- --config skip_children=true `find ./parquet -name "*.rs" \! -name format.rs`
alamb marked this conversation as resolved.
Show resolved Hide resolved
cargo fmt -p parquet -- --check --config skip_children=true `find . -name "*.rs" \! -name format.rs`
- name: Format object_store
working-directory: object_store
run: cargo fmt --all -- --check
Expand Down
Loading