Skip to content

Commit

Permalink
Merge pull request #662 from apache/feature/509-remove-static-dm-libs
Browse files Browse the repository at this point in the history
#509: Remove static dm libs (dm is integral part of framework)
  • Loading branch information
pnoltes authored Oct 7, 2023
2 parents 86379aa + 955d58f commit d61be60
Show file tree
Hide file tree
Showing 8 changed files with 6 additions and 298 deletions.
5 changes: 5 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,12 @@ limitations under the License.

# Noteworthy Changes for 3.0.0 (TBD)

## Backwards incompatible changes

- Deployment Admin bundle has been removed and is no longer supported.
- The libs `dependency_manager_static`, `shell_dm` and `dependency_manager_cxx_static` are removed. These libraries are
not needed anymore. The dependency manager is an integral part of the framework lib and the `dm` command is part
of the standard shell commands.

# Noteworthy Changes for 2.4.0 (2023-09-27)

Expand Down
8 changes: 1 addition & 7 deletions conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ class CelixConan(ConanFile):
"build_pushstreams": False,
"build_experimental": False,
"build_celix_dfi": False,
"build_dependency_manager": False,
"build_dependency_manager_cxx": False,
"build_framework": False,
"build_rcm": False,
"build_utils": False,
Expand Down Expand Up @@ -315,13 +313,9 @@ def configure(self):
if options["build_rcm"]:
options["build_utils"] = True

if options["build_launcher"] or options["build_dependency_manager"]:
if options["build_launcher"]:
options["build_framework"] = True

if options["build_dependency_manager_cxx"]:
options["build_framework"] = True
options["celix_cxx14"] = True

if options["build_celix_dfi"]:
options["build_utils"] = True

Expand Down
7 changes: 0 additions & 7 deletions libs/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,7 @@ add_subdirectory(framework)
#launcher
add_subdirectory(launcher)

#add_subdirectory(event_admin)# event_admin is unstable
add_subdirectory(dependency_manager)
if (CELIX_CXX14)
add_subdirectory(dependency_manager_cxx)
endif ()

# Error Injectors
if (ENABLE_TESTING AND EI_TESTS)
add_subdirectory(error_injector)
endif ()

58 changes: 0 additions & 58 deletions libs/dependency_manager/CMakeLists.txt

This file was deleted.

54 changes: 0 additions & 54 deletions libs/dependency_manager/api/dm_activator.h

This file was deleted.

42 changes: 0 additions & 42 deletions libs/dependency_manager/src/dm_activator.c

This file was deleted.

38 changes: 0 additions & 38 deletions libs/dependency_manager_cxx/CMakeLists.txt

This file was deleted.

92 changes: 0 additions & 92 deletions libs/dependency_manager_cxx/src/dm_activator.cc

This file was deleted.

0 comments on commit d61be60

Please sign in to comment.