Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/511 remove resolver #601

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Conversation

PengZheng
Copy link
Contributor

This PR removes resolver and related codes from the framework, including:

The removal should be safe, considering "export-library/import-library" has never been production ready.
It can be viewed as a preparatory step towards reintroducing Requirement-Capability Model (#511).

This was done as the example was outdated and caused confusion as it did not reflect the current state of the Celix library. Clearing out such outdated references keeps the examples relevant and avoids spreading incorrect or outdated information about the library usage.
# Conflicts:
#	libs/framework/CMakeLists.txt
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #601 (df6efe0) into master (2683e8b) will increase coverage by 1.14%.
The diff coverage is 36.36%.

❗ Current head df6efe0 differs from pull request most recent head 4ce9a10. Consider uploading reports for the commit 4ce9a10 to get more accurate results

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   78.56%   79.71%   +1.14%     
==========================================
  Files         260      256       -4     
  Lines       35415    34686     -729     
==========================================
- Hits        27824    27649     -175     
+ Misses       7591     7037     -554     
Files Changed Coverage Δ
libs/framework/src/bundle.c 70.76% <ø> (-0.16%) ⬇️
libs/framework/src/manifest_parser.c 92.85% <ø> (+60.79%) ⬆️
libs/framework/src/module.c 83.00% <0.00%> (+8.63%) ⬆️
libs/framework/src/celix_launcher.c 92.35% <100.00%> (ø)
libs/framework/src/framework.c 84.86% <100.00%> (-0.11%) ⬇️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@pnoltes pnoltes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal should be safe, considering "export-library/import-library" has never been production ready.

I agree, LGTM

@PengZheng PengZheng merged commit 072cba2 into master Aug 2, 2023
22 checks passed
@PengZheng PengZheng deleted the feature/511-remove-resolver branch August 2, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken manifestParser_parseExport(Import)Header
3 participants