Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/more auto cleanup #609

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Feature/more auto cleanup #609

merged 2 commits into from
Aug 10, 2023

Conversation

PengZheng
Copy link
Contributor

@PengZheng PengZheng commented Aug 6, 2023

This PR adds auto cleanup to the remaining utils API.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2023

Codecov Report

Merging #609 (a2bf6a7) into master (2eae9c2) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 70.83%.

❗ Current head a2bf6a7 differs from pull request most recent head 7311ec5. Consider uploading reports for the commit 7311ec5 to get more accurate results

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
- Coverage   79.71%   79.70%   -0.01%     
==========================================
  Files         256      258       +2     
  Lines       34686    34675      -11     
==========================================
- Hits        27649    27639      -10     
+ Misses       7037     7036       -1     
Files Changed Coverage Δ
libs/framework/src/framework.c 84.99% <0.00%> (+0.10%) ⬆️
bundles/pubsub/pubsub_utils/src/pubsub_utils.c 68.60% <100.00%> (-0.72%) ⬇️
...ndles/remote_services/topology_manager/src/scope.c 73.71% <100.00%> (+0.30%) ⬆️
...e_services/topology_manager/src/topology_manager.c 83.33% <100.00%> (-0.11%) ⬇️
libs/framework/src/bundle_context.c 77.87% <100.00%> (ø)
libs/framework/src/service_registry.c 73.42% <100.00%> (-0.16%) ⬇️
libs/utils/include/celix_filter.h 100.00% <100.00%> (ø)
libs/utils/include/celix_version_range.h 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@pnoltes pnoltes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PengZheng PengZheng merged commit eb30eb5 into master Aug 10, 2023
22 checks passed
@PengZheng PengZheng deleted the feature/more-auto-cleanup branch August 10, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants