Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add celix err message print in fw after each bundle start #693

Merged
merged 4 commits into from
Dec 10, 2023

Conversation

pnoltes
Copy link
Contributor

@pnoltes pnoltes commented Dec 3, 2023

This PR add a print of the unprocessed celix err messages after every bundle start.

Ideally errors and therefore celix err messages are handled by the bundle activators, but if this is not done this update will inform users that there are unprocessed celix err messages.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (95bbcfc) 83.11% compared to head (667756b) 83.42%.
Report is 9 commits behind head on master.

❗ Current head 667756b differs from pull request most recent head bc31fbc. Consider uploading reports for the commit bc31fbc to get more accurate results

Files Patch % Lines
libs/dfi/src/dyn_avpr_type.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
+ Coverage   83.11%   83.42%   +0.31%     
==========================================
  Files         254      254              
  Lines       32929    32988      +59     
==========================================
+ Hits        27369    27521     +152     
+ Misses       5560     5467      -93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@PengZheng PengZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

libs/framework/src/framework.c Outdated Show resolved Hide resolved
@pnoltes pnoltes merged commit b064ad7 into master Dec 10, 2023
28 checks passed
@pnoltes pnoltes deleted the feature/print-celix-err-after-bnd-start branch December 10, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants