Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/use steady_clock to handle backward system clock adjustments #698

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

PengZheng
Copy link
Contributor

Monotonic clock should be used to handle backward system clock adjustments correctly.
This PR is a tiny "last boy scout rule" cleanup.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8956987) 83.47% compared to head (3e1a6b9) 84.25%.
Report is 9 commits behind head on master.

❗ Current head 3e1a6b9 differs from pull request most recent head 6e364bb. Consider uploading reports for the commit 6e364bb to get more accurate results

Files Patch % Lines
...te_service_admin_dfi/src/import_registration_dfi.c 0.00% 1 Missing ⚠️
libs/framework/include/celix/BundleActivator.h 50.00% 1 Missing ⚠️
...ramework/include/celix/dm/ServiceDependency_Impl.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
+ Coverage   83.47%   84.25%   +0.77%     
==========================================
  Files         254      248       -6     
  Lines       32988    31124    -1864     
==========================================
- Hits        27538    26223    -1315     
+ Misses       5450     4901     -549     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PengZheng PengZheng merged commit 886f2fd into master Dec 14, 2023
28 checks passed
@PengZheng PengZheng deleted the hotfix/system-clock-replace branch December 14, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants