Add build job for dev container (and small fixes) #717
Conversation
This matches more with the concept of passing custom commands, where a container can be started and exited
This because: * The 'build' directory is already ignored in the .gitignore * The 'build' directory is used in other examples on the Celix website
This allows to execute chained commands. For example: ./run-ubuntu-container.sh "mkdir -p build && cd build && ../container/support-scripts/build-all.sh && make -j"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 212 212
Lines 24039 24039
=======================================
Hits 21238 21238
Misses 2801 2801 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
LGTM
I just noticed that discovery_zeroconf currently works only with Conan on Linux. Considering avahi provide avahi-compat-libdns_sd for apple's Bonjour API, it should be possible to make discovery_zeroconf work with avahi. Note that dns-sd is a first class citizen on macOS, it should also work on macOS. I created a separate issue (#718 ) for this.
This fixes #700