Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linux-build-apt to use ninja. #760

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

PengZheng
Copy link
Contributor

This PR remove irrelevant check which causes temporary CI failure and update linux-build-apt to use Ninja.

https://github.com/apache/celix/actions/runs/9883280941/job/27299892915#step:6:47

Run mkdir build install
-- The C compiler identification is GNU 11.4.0
-- The CXX compiler identification is GNU 11.4.0
-- The ASM compiler identification is GNU
-- Found assembler: /usr/bin/cc
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
CMake Error at CMakeLists.txt:36 (message):
  Building Celix using CMake 3.3 and makefiles is not supported due to a bug
  in the Makefile Generator (see Bug 15696).  Please change the used CMake
  version - both, CMake 3.2 and CMake 3.4 are working fine.  Or use a
  different generator (e.g.  Ninja).
-- Configuring incomplete, errors occurred!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (758aa79) to head (bfccf0e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
+ Coverage   90.25%   90.31%   +0.06%     
==========================================
  Files         226      226              
  Lines       26320    26320              
==========================================
+ Hits        23755    23772      +17     
+ Misses       2565     2548      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PengZheng PengZheng merged commit c533db4 into master Jul 11, 2024
32 checks passed
@PengZheng PengZheng deleted the hotfix/update-ubuntu-CI branch July 11, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants