Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes grammar and typos in Javadoc #233

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Fixes grammar and typos in Javadoc #233

merged 1 commit into from
Jul 21, 2023

Conversation

mawiesne
Copy link
Contributor

  • fixes grammar issues in JavaDoc and code comments.
  • fixes some typos found along the way.
  • improves JavaDoc, highlighting the keywords: null, true, false.

fixes some typos found along the way.
improves JavaDoc, highlighting the keywords: null, true, false.
@codecov-commenter
Copy link

Codecov Report

Merging #233 (3422e3e) into master (e0d6fe0) will increase coverage by 0.38%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #233      +/-   ##
============================================
+ Coverage     74.65%   75.04%   +0.38%     
- Complexity      445      448       +3     
============================================
  Files            38       38              
  Lines          1823     1823              
  Branches        181      181              
============================================
+ Hits           1361     1368       +7     
+ Misses          348      341       -7     
  Partials        114      114              
Impacted Files Coverage Δ
...rc/main/java/org/apache/commons/crypto/Crypto.java 80.48% <ø> (ø)
...va/org/apache/commons/crypto/NativeCodeLoader.java 50.00% <ø> (ø)
...rc/main/java/org/apache/commons/crypto/OsInfo.java 66.12% <ø> (ø)
...org/apache/commons/crypto/cipher/CryptoCipher.java 100.00% <ø> (ø)
...va/org/apache/commons/crypto/cipher/JceCipher.java 75.00% <ø> (ø)
...java/org/apache/commons/crypto/cipher/OpenSsl.java 80.48% <ø> (ø)
...rg/apache/commons/crypto/cipher/OpenSslCipher.java 75.60% <ø> (ø)
...ommons/crypto/cipher/OpenSslGaloisCounterMode.java 66.66% <ø> (ø)
...java/org/apache/commons/crypto/jna/OpenSslJna.java 60.00% <ø> (ø)
...rg/apache/commons/crypto/jna/OpenSslJnaCipher.java 80.24% <ø> (+3.70%) ⬆️
... and 6 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mawiesne
Copy link
Contributor Author

ping @kinow & @garydgregory

@garydgregory garydgregory merged commit 410e3b0 into apache:master Jul 21, 2023
13 checks passed
@garydgregory garydgregory changed the title Fixes grammar and typos and optimizes JavaDoc Fixes grammar and typos in Javadoc Jul 21, 2023
garydgregory added a commit that referenced this pull request Jul 21, 2023
@mawiesne mawiesne deleted the Fixes_grammar_and_typos_and_optimizes_JavaDoc branch July 21, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants