Set MacOS Runner to 11 and Fix Unknown Method Error #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Including the console output for the unit tests. |
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
============================================
- Coverage 75.04% 74.65% -0.39%
+ Complexity 448 445 -3
============================================
Files 38 38
Lines 1823 1823
Branches 181 181
============================================
- Hits 1368 1361 -7
- Misses 341 348 +7
Partials 114 114
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a fork and build to get reacclimatized to the code base. A few observations. One, the build contained an unknown method error. Two, the test matrix was pulling macos-latest, which used OpenSSL3 and broke the tests. Three, the CI pipeline isn't running the full set of tests. This PR addresses the first two issues. I'm not sure what the rationale was for running only a small subset of tests in GitHub actions, but we may want to consider running them all, at least in some of the matrix builds.