CB-12129 (android): Add ability to set dialog style #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty, and logic to set a custom dialog style. Updated readme with new method and setup info.
|
Thanks for the PR, but CB-12129 is closed and it's not exactly the same as what you implemented. So it's better if you create a new issue and use the new id instead of CB-12129. Also, for new features, specially if they are platform specific, is recommended to send a mail to the cordova dev list ( dev@cordova.apache.org ) so it can be discussed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
What does this PR do?
Created new
setAndroidStyleNamefunction to allow specifying the name of a style to apply to dialogs on Android. Also updated README to explain how to create a named style and copy it to the correct location.What testing has been done on this change?
Tested on Android 7.1.1 emulator.
Checklist