-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky windows test #4406
base: main
Are you sure you want to change the base?
Fix flaky windows test #4406
Conversation
Runs through... |
On Windows it seems the sockets are closed and we get the `connection_closed` error. Account for that error as well as a 400 or a `request_failed` response. It behaves differently on Windows. At some point in the future investigate the details but for now let's just bypass it.
We made too strong of an assumption there that even in the case of Q=8 we'd always have 2 pending changes, which is incorrect. The tests on Windows apprently revealed an error where it returned 0. So let's relax the assumption to assert that pending would be >= 0 and something less than 7.
c2498a9
to
86d7ee6
Compare
Running
|
Would add one additional fixture setup failure...
|
Hmm, that one is unexpected. We're just trying to create a db with a PUT and we should expect that to always work:
With the small buffer socket test, I can see how connection might be closed suddenly or in a different way on Windows but the simple doc PUT in a security test setup points to something else going on. Could we be running out of sockets? Not sure descriptor limit a thing on Windows?. Try running just that one security test separately, wonder if that would fail. Another idea is that there is a genuine race or bug somewhere in couch/ibrowse/mochiweb/erlang vm code that is exposed on Windows only. |
Moved into #4398 ... |
This PR bypasses the socket tests on windows and fixes a flaky chttpd changes tests where we made a too strong of an assumption about the order in which the shards would be returned.
Thanks to @big-r81 for investigating both issues!
See #4401 (comment) for his windows test failure report.