feat: expose between #868
Merged
feat: expose between #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-J-Ward
requested changes
Sep 10, 2024
| @@ -293,6 +293,17 @@ impl PyExpr { | |||
| expr.into() | |||
| } | |||
|
|
|||
| #[pyo3(signature = (low, high, negated=false))] | |||
There was a problem hiding this comment.
With the introduction of the python wrappers, we've been preferring to avoid #[pyo3(signature = ...)] annotations for simple defaults and let the python wrappers handle them.
(I see that I left that out of the guidelines, I'll throw a quick PR for that.)
There was a problem hiding this comment.
FYI for optionals we might have to have these signatures in when we upgrade to pyo3 0.22. It's part of the DF42 update PR that's up
There was a problem hiding this comment.
So, do you folks think I should remove it?
There was a problem hiding this comment.
I think it should be kept in as we'll have to add it anyways once the pyo3 0.22 upgrade hits #867
There was a problem hiding this comment.
Yes, leave it in for now.
Michael-J-Ward
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #809.
Are there any user-facing changes?
Yes