-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PostgreSQL LISTEN/NOTIFY
syntax
#1485
Add support for PostgreSQL LISTEN/NOTIFY
syntax
#1485
Conversation
LISTEN/NOTIFY
syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
e71f9cf
to
e6c96b9
Compare
Sorry, I mixed up the documentation links for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wugeer just one comment around the naming otherwise I think this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Test Coverage Report for Build 11685106929Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
6ff8f27
to
b9cbd1a
Compare
Will look to merge this given we're pending only a ci run |
Woohoo -- it is great to see you merging PRs @iffyio |
This PR supports
LISTEN/NOTIFY
clause for postgres dialect,. For more information, please refer to:https://www.postgresql.org/docs/current/sql-listen.html
https://www.postgresql.org/docs/current/sql-notify.html
It also introduces the following keywords:
This resolves issue #1481