refactor: based upon performance tests, run the maximum number of che…

…cks without impa ct:

* assert_valid_optimization can run each optimizer pass
* remove the recursive cehck_fields, which caused the performance regression
* the full LP Invariants::Executable can only run in debug

datafusion/expr/src/logical_plan/invariants.rs

@@ -59,13 +59,7 @@ pub fn assert_executable_invariants(plan: &LogicalPlan) -> Result<()> {
 /// This invariant is subject to change.
 /// refer: <https://github.com/apache/datafusion/issues/13525#issuecomment-2494046463>
 fn assert_unique_field_names(plan: &LogicalPlan) -> Result<()> {
-    plan.schema().check_names()?;
-
-    plan.apply_with_subqueries(|plan: &LogicalPlan| {
-        plan.schema().check_names()?;
-        Ok(TreeNodeRecursion::Continue)
-    })
-    .map(|_| ())
+    plan.schema().check_names()
 }
 
 /// Returns an error if the plan is not sematically valid.

datafusion/optimizer/src/optimizer.rs

@@ -386,7 +386,6 @@ impl Optimizer {
                     .skip_failed_rules
                     .then(|| new_plan.clone());
 
-                #[cfg(debug_assertions)]
                 let starting_schema = Arc::clone(new_plan.schema());
 
                 let result = match rule.apply_order() {
@@ -398,15 +397,16 @@ impl Optimizer {
                     None => optimize_plan_node(new_plan, rule.as_ref(), config),
                 }
                 .and_then(|tnr| {
-                    // in debug mode, run checks are each optimer pass
-                    #[cfg(debug_assertions)]
+                    // run checks optimizer invariant checks, per pass
                     assert_valid_optimization(&tnr.data, &starting_schema)
                         .map_err(|e| {
                             DataFusionError::Context(
                                 format!("check_optimizer_specific_invariants after optimizer pass: {}", rule.name()),
                                 Box::new(e),
                             )
                         })?;
+
+                    // run LP invariant checks only in debug
                     #[cfg(debug_assertions)]
                     tnr.data.check_invariants(InvariantLevel::Executable)
                         .map_err(|e| {