Fix ScalarValue::to_array_of_size for DenseUnion
#13797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also validated in geoarrow/geoarrow-rs#951 that this is now working for storing geospatial geometries in a dense union! Mirroring the PostGIS Under the hood this is stored as a rather complex dense union, but allows for any combination of geometry type and dimension with a unique DataType that's streaming-friendly. |
kylebarron
added a commit
to geoarrow/geoarrow-rs
that referenced
this pull request
Dec 16, 2024
Ref apache/datafusion#13797. This is now working for geometries! ``` SELECT ST_GeomFromText('LINESTRING(-71.160281 42.258729,-71.160837 42.259113,-71.161144 42.25932)'); ``` ``` ---- udf::native::io::wkt::test::test stdout ---- +----------------------------------------------------------------------------------------------------+ | st_geomfromtext(Utf8("LINESTRING(-71.160281 42.258729,-71.160837 42.259113,-71.161144 42.25932)")) | +----------------------------------------------------------------------------------------------------+ | {=[{x: -71.160281, y: 42.258729}, {x: -71.160837, y: 42.259113}, {x: -71.161144, y: 42.25932}]} | +----------------------------------------------------------------------------------------------------+ ``` 🚀
alamb
approved these changes
Dec 16, 2024
| new_null_array(dt, size) | ||
| match mode { | ||
| UnionMode::Sparse => new_null_array(dt, size), | ||
| // In a dense union, only the child with values needs to be |
There was a problem hiding this comment.
I double checked the spec and I agree with this check: https://arrow.apache.org/docs/format/Columnar.html#dense-union
| @@ -5642,14 +5650,12 @@ mod tests { | |||
| // null array | |||
| Arc::new(NullArray::new(3)), | |||
| // dense union | |||
| /* Dense union fails due to https://github.com/apache/datafusion/issues/13762 | |||
| { | |||
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13762
Rationale for this change
Fix support for dense union.
What changes are included in this PR?
Fix
ScalarValue::to_array_of_sizefor DenseUnionAre these changes tested?
Yes. The test from #13777 is uncommented.
Are there any user-facing changes?