Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: cargo update in datafusion-cli #13801

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 16, 2024

Which issue does this PR close?

Part of

Rationale for this change

I needed to update Cargo.lock in datafusion-cli as part of #13663 and I hit some MSRV problem related to home

I wanted to fix it in a separate PR rather than try and include it as part of the arrow upgrade.

When I did cargo update in the datafusion-cli directory, the MSRV check fails:

Specifically, home 0.5.11 has a MSRV of 1.81 which is too new to pass our CI check
-- Updating home v0.5.9 -> v0.5.11

andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2/datafusion-cli$ cargo msrv verify
  [Meta]   cargo-msrv 0.17.1

Compatibility Check #1: Rust 1.80.1
  [FAIL]   Is incompatible

  ╭────────────────────────────────────────────────────────────────────────╮
  │ error: rustc 1.80.1 is not supported by the following package:         │
  │   home@0.5.11 requires rustc 1.81                                      │
  │ Either upgrade rustc or select compatible dependency versions with     │
  │ `cargo update <name>@<current-ver> --precise <compatible-ver>`         │
  │ where `<compatible-ver>` is the latest version supporting rustc 1.80.1 │
  ╰────────────────────────────────────────────────────────────────────────╯
Crate source was found to be incompatible with Rust version '1.80.1' specified as MSRV in the Cargo manifest located at '/Users/andrewlamb/Software/datafusion2/datafusion-cli/Cargo.toml'

What changes are included in this PR?

  1. Pin home to 0.5.9
  2. cargo update in datafusion-cli
  3. Check in the result

Are these changes tested?

Are there any user-facing changes?

Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahgao jonahgao merged commit e665115 into apache:main Dec 17, 2024
27 checks passed
@alamb alamb deleted the alamb/update-datafusion-cli branch December 17, 2024 12:21
@alamb
Copy link
Contributor Author

alamb commented Dec 17, 2024

Thanks @jonahgao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants