[bugfix] ScalarFunctionExpr does not preserve the nullable flag on roundtrip #13830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Thank you @ccciudatu -- this looks like a good fix and good test coverage to me.
|
Thanks again ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13829.
Rationale for this change
Preserve the nullable flag for scalar functions after a ser/deser roundtrip.
What changes are included in this PR?
nullablefield in the proto file and using it to propagate the flag on serialization.Are these changes tested?
The first commit is a test that fails and the subsequent commits make it pass.
Are there any user-facing changes?
No