Minor: Replace BooleanArray::extend with append_n
#13832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the review |
Dandandan
reviewed
Dec 19, 2024
| self.output_record_batches | ||
| .row_indices | ||
| .extend(&UInt64Array::from(vec![None; num_rows])); | ||
| .append_nulls(num_rows); | ||
| self.output_record_batches | ||
| .batch_ids | ||
| .extend(vec![0; num_rows]); |
There was a problem hiding this comment.
Btw this could avoid some allocation as well (using resize rather than extend based on Vec)
There was a problem hiding this comment.
good point, I'll check if there are other use cases we can modify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13144.
Rationale for this change
More concise and potentially more performant API
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?