Support n-ary monotonic functions in ordering equivalence #13841
+269
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions for `ConcatFunc`
github-actions
bot
added
logical-expr
Note about Cargo.toml changesI added |
gokselk
changed the title
jayzhan211
reviewed
Dec 19, 2024
datafusion/physical-expr/Cargo.toml
Outdated
| @@ -44,6 +44,7 @@ arrow-schema = { workspace = true } | |||
| datafusion-common = { workspace = true, default-features = true } | |||
| datafusion-expr = { workspace = true } | |||
| datafusion-expr-common = { workspace = true } | |||
| datafusion-functions = { workspace = true } | |||
There was a problem hiding this comment.
since only test requires this, maybe move to dev-dependencies
There was a problem hiding this comment.
or maybe move the test in datafusion/core/tests 🤔
There was a problem hiding this comment.
I've moved it to dev-dependencies for now
ozankabak
approved these changes
Dec 19, 2024
|
will be merged once CI passes one more time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13839.
Rationale for this change
DataFusion's ordering equivalence system currently only handles single-parameter monotonic functions. This PR extends support to N-ary functions that preserve lexicographical ordering, like concat(). This enables more optimization opportunities when working with ordered data.
What changes are included in this PR?
preserves_lex_orderingfield toExprPropertiesoutput_preserves_lex_orderingfor concat functiondiscover_new_orderings()to handle multiple parametersAre these changes tested?
Yes, added three new test cases:
Are there any user-facing changes?
No user-facing changes. This is an internal optimization improvement.