Support 1 or 3 arg in generate_series() UDTF #13856
Open
+149
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UBarney
force-pushed
the
gen_series_1_and_3_args
branch
2 times, most recently
from
935610b to
93520be
Compare
UBarney
force-pushed
the
gen_series_1_and_3_args
branch
from
93520be to
5803583
Compare
goldmedal
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
Thanks @UBarney. Overall looks good to me but some minor comments.
cc @2010YOUY01
Comment on lines
+33
to
+38
| #[derive(Debug, Clone)] | ||
| enum GenSeriesArgs { | ||
| ContainsNull, | ||
| AllNotNullArgs { start: i64, end: i64, step: i64 }, | ||
| } | ||
|
|
There was a problem hiding this comment.
It's better to add some doc for the enum and its variants.
| ContainsNull, | ||
| AllNotNullArgs { start: i64, end: i64, step: i64 }, | ||
| } | ||
|
|
||
| /// Table that generates a series of integers from `start`(inclusive) to `end`(inclusive) |
There was a problem hiding this comment.
I believe the comment should be updated for step.
| start: Option<i64>, | ||
| // None if input is Null | ||
| end: Option<i64>, | ||
| args: GenSeriesArgs, | ||
| } | ||
|
|
||
| /// Table state that generates a series of integers from `start`(inclusive) to `end`(inclusive) |
There was a problem hiding this comment.
Same as above. It should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13615.
Rationale for this change
What changes are included in this PR?
GenerateSeriesTablestepfield toGenerateSeriesState, and added support for generating series with custom stepAre these changes tested?
sqllogictests for generate_series() UDTF
Are there any user-facing changes?
No