Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build use of undeclared type ShowStatementFilter #13869

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 21, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Build on main is broken due to a logical conflict between

Example failure:

https://github.com/apache/datafusion/actions/runs/12441590178/job/34738687199

error[E0433]: failed to resolve: use of undeclared type `ShowStatementFilter`
    --> datafusion/sql/src/statement.rs:2003:17
     |
2003 |                 ShowStatementFilter::Like(like) => {
     |                 ^^^^^^^^^^^^^^^^^^^ use of undeclared type `ShowStatementFilter`
     |
help: a struct with a similar name exists
     |
2003 |                 ShowStatementIn::Like(like) => {
     |                 ~~~~~~~~~~~~~~~
help: consider importing one of these enums
     |
18   + use crate::statement::ast::ShowStatementFilter;
     |
18   + use sqlparser::ast::ShowStatementFilter;
     |

    Checking datafusion-functions v43.0.0 (/__w/datafusion/datafusion/datafusion/functions)
    Checking datafusion-physical-plan v43.0.0 (/__w/datafusion/datafusion/datafusion/physical-plan)
    Checking datafusion-functions-aggregate v43.0.0 (/__w/datafusion/datafusion/datafusion/functions-aggregate)
Some errors have detailed explanations: E0[412](https://github.com/apache/datafusion/actions/runs/12441590178/job/34738687199#step:6:413), E0433.

What changes are included in this PR?

Fix logical conflict

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sql SQL Planner label Dec 21, 2024
@alamb alamb changed the title Fix build Fix build use of undeclared type ShowStatementFilter`` Dec 21, 2024
@alamb alamb changed the title Fix build use of undeclared type ShowStatementFilter`` Fix build use of undeclared type ShowStatementFilter Dec 21, 2024
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb for fixing it 👍

@goldmedal goldmedal merged commit ede665b into apache:main Dec 21, 2024
26 checks passed
@alamb alamb deleted the alamb/build branch December 21, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants