Minor: change visibility of hash join utils #13893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozankabak
approved these changes
Dec 24, 2024
alamb
reviewed
Dec 24, 2024
| @@ -176,7 +176,7 @@ fn swap_join_projection( | |||
| /// This function swaps the inputs of the given join operator. | |||
| /// This function is public so other downstream projects can use it | |||
| /// to construct `HashJoinExec` with right side as the build side. | |||
| pub fn swap_hash_join( | |||
| pub(crate) fn swap_hash_join( | |||
There was a problem hiding this comment.
I believe this is actually a downgrade of visibility -- it used to be pub but now is pub(crate) meaning that comet can't use it: #13898
I will make a PR to fix this
There was a problem hiding this comment.
Oops, sorry for that. I guess we hastily thought pub(crate) would be sufficient but in Comet's case they need the full pub.
There was a problem hiding this comment.
No worries -- it was easily fixed
This was referenced Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
These functions can be used in other modules across the crate, so I'm relaxing their accessibility.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?