Correct return type for initcap scalar function with utf8view #13909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e return type specified in the return_type function
timsaucer
changed the title
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Dec 28, 2024
…#13909) * Set utf8view as return type when input type is the same * Verify that the returned type from call to scalar function matches the return type specified in the return_type function * Match return type to utf8view
alamb
added a commit
that referenced
this pull request
Dec 28, 2024
#13934) * Set utf8view as return type when input type is the same * Verify that the returned type from call to scalar function matches the return type specified in the return_type function * Match return type to utf8view Co-authored-by: Tim Saucer <timsaucer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13907
Rationale for this change
Described in the issue, when the input type is utf8view for initcap, so should the return type. The actual return type is utf8view, so we just need to set it in the
return_typefunction to match.What changes are included in this PR?
One change to return_type function
Are these changes tested?
Tested in datafusion-python unit tests. I also updated the unit test macro to validate that data types returned from scalar functions matches those that are expected, which is why this problem was not identified previously.
Are there any user-facing changes?
None