doc-gen: migrate scalar functions (string) documentation 1/4 #13924
Conversation
|
I believe you may have forgotten to run the doc generation script prior to pushing this change |
|
@Omega359 Yes 😢 I'll run doc generation script for other PRs all together. Thanks for reviewing 🙏 |
github-actions
bot
added
the
documentation
| ```sql | ||
| trim(trim_str FROM str) | ||
| ``` |
There was a problem hiding this comment.
@comphead I found that use_doc() only supports one alternative syntax. Should we modify it to support multiple alternative syntaxes?
There was a problem hiding this comment.
oh its a vec, yeah we should do it, as well as simplify a little bit the Documentation structure to replace Option<Vec> to just Vec
There was a problem hiding this comment.
Lets leave trim not migrated for now and we can do it once the doc macros fixed
There was a problem hiding this comment.
There was a problem hiding this comment.
I remove the change for trim() in this PR, thanks! I'd like to update use_doc() and migrate trim() simultaneously
Chen-Yuan-Lai
force-pushed
the
migrate_scalar_functions_string_1/4
branch
from
dcda1b8 to
bd8033e
Compare
github-actions
bot
removed
the
documentation
Which issue does this PR close?
Part of #13671 .
Rationale for this change
What changes are included in this PR?
As discussed in #13671 , this PR will migrate the parts of builtin string functions documentation that currently support migration.
Are these changes tested?
Are there any user-facing changes?