[DSIP-38] Optimize dependency tree #16838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
requested review from
caishunfeng,
ruanwenjun,
songjianet,
Gallardot and
EricGao888
as code owners
SbloodyS
force-pushed
the
improvement_16098
branch
from
c6aba31
to
208636f
Compare
|
ruanwenjun
reviewed
Nov 25, 2024
| @@ -1438,7 +1437,7 @@ private TaskDefinitionLog buildNormalSqlTaskDefinition(String taskName, DataSour | |||
| sqlParameters.setLocalParams(Collections.emptyList()); | |||
| taskDefinition.setTaskParams(JSONUtils.toJsonString(sqlParameters)); | |||
| taskDefinition.setCode(CodeGenerateUtils.genCode()); | |||
| taskDefinition.setTaskType(SqlTaskChannelFactory.NAME); | |||
| taskDefinition.setTaskType("SQL"); | |||
There was a problem hiding this comment.
We need to use enum or constant, otherwise once the type has been changed, it's hard to know we need to make change here.
| @@ -63,13 +63,19 @@ | |||
|
|
|||
| <dependency> | |||
| <groupId>org.apache.dolphinscheduler</groupId> | |||
| <artifactId>dolphinscheduler-datasource-all</artifactId> | |||
| <artifactId>dolphinscheduler-common</artifactId> | |||
There was a problem hiding this comment.
It's better to change dolphinscheduler-datasource-all to provided rather than remove it, once we remove it, no one can find the module relation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16098
Brief change log
The binary package
apache-dolphinscheduler-dev-SNAPSHOT-bin.tar.gzsize is 912M with the following fileVerify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md